Restore self-contained Windows App SDK packaging#4488
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intomainfrom Mar 17, 2026
Merged
Restore self-contained Windows App SDK packaging#4488Marc-André Moreau (mamoreau-devolutions) merged 1 commit intomainfrom
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intomainfrom
Conversation
The shared-target-framework refactor moved the Windows App SDK self-contained settings into Directory.Build.props behind a condition that depends on TargetFramework being set. Because Directory.Build.props is evaluated before UniGetUI.csproj assigns TargetFramework, the app project stopped evaluating as self-contained and no longer bundled Microsoft.WindowsAppRuntime.dll in release artifacts. Move the self-contained Windows App SDK settings into UniGetUI.csproj so they are evaluated after the app TargetFramework is known and the runtime payload is bundled again. Fixes #4487.
Benoît Cortier (CBenoit)
approved these changes
Mar 17, 2026
Marc-André Moreau (mamoreau-devolutions)
merged commit 6db8ab3
into
main
1 check passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
fix-windows-app-runtime-issue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
A shared-target-framework refactor moved the Windows App SDK self-contained settings into Directory.Build.props behind a condition that depends on TargetFramework. Directory.Build.props is imported before UniGetUI.csproj sets TargetFramework, so the condition stopped matching for the app project. That silently disabled app-local Windows App SDK packaging and release artifacts stopped including Microsoft.WindowsAppRuntime.dll.
Validation
Fixes #4487