Fix deterministic resource lifetimes#5070
Merged
Merged
Conversation
Dispose HTTP, process, COM, image, task, and UI subscription resources deterministically; add cancellation and lifetime regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Prevent cancellation, retry, and disposal races from overlapping operation runs or corrupting terminal state. Add focused regression coverage for cleanup ordering, repeated retries, startup failures, queue cancellation, and disposal boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Gabriel Dufresne (GabrielDuf)
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operation lifecycle correctness
A follow-up GPT-5.6 Sol audit traced cancellation, retry, disposal, queueing, and terminal-event interleavings in
AbstractOperation. It found and fixed races that could:CancellationTokenSourceafter concurrent completion disposed it;Enqueuedwhile the queue was full.Runs now publish their task and cancellation owner atomically, concurrent
MainThread()calls share one active run, retries wait for prior cleanup and retain follow-up requests, and disposal prevents pending or future runs without corrupting terminal state.Coverage
MainThread()calls, retry serialization, repeated retry callbacks, deferred-retry disposal, terminal/startup-failure disposal, retry-option failure recovery, and cancellation during queue admission.Deferred follow-up
Static caches, logs, IPC output, and operation history remain unchanged. Their bounds and eviction policies will be selected only after representative UI/package workloads provide reliable
dotnet-countersand GC-dump evidence.Validation
dotnet test UniGetUI.Windows.slnx --no-restore --verbosity q --nologo /p:Platform=x64 -m:1net10.0andnet10.0-windows10.0.26100.0.