chore: extend lint coverage to the fuzz and wasm paths - #410
Merged
Mathieu Morrissette (mmorrissette-devolutions) merged 1 commit intoAug 10, 2026
Merged
Conversation
Clippy only ever ran with default features, leaving the `wbindgen` and `fuzz` cfg paths unlinted. Add both to the CI lint action and fix the lint debt they surfaced. - ci: lint `--features fuzz` and `--target wasm32-unknown-unknown --features wbindgen --all-targets`. The wbindgen deps live under [target.wasm32-unknown-unknown.dependencies], so that feature only resolves against the wasm target. - wasm: fix 11 clippy warnings (needless borrows, unwrap_or(Vec::new()) -> unwrap_or_default(), an identity .into()) plus one in tests/web.rs. - fuzz: mark the libfuzzer bins test/doc/bench = false so `cargo test --workspace` links instead of failing with LNK1561. - utils: fence the `validate_header` doc example so it is compiled, and fix it -- `generate_key` is fallible and the asserts had unbalanced parens. - utils, password_hash: surface the discarded pbkdf2 Result with an expect() documenting why it cannot fail. - error: drop a dead commented-out impl block.
Mathieu Morrissette (mmorrissette-devolutions)
marked this pull request as ready for review
August 10, 2026 18:08
Mathieu Morrissette (mmorrissette-devolutions)
requested a review
from a team
as a code owner
August 10, 2026 18:08
Richard Boisvert (rbstp)
approved these changes
Aug 10, 2026
Mathieu Morrissette (mmorrissette-devolutions)
merged commit Aug 10, 2026
31ebbae
into
master
34 checks passed
Mathieu Morrissette (mmorrissette-devolutions)
deleted the
chore/lint-coverage-and-hygiene
branch
August 10, 2026 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.