docs: collapse duplicate README filtering paragraph - #323
Conversation
The service-list filtering paragraph was duplicated during the browser PR merges. Neither copy was complete: the stale one listed CloudFormation stacks, the newer one listed Auto Scaling groups, DynamoDB tables, and EventBridge rules and targets. Keep a single paragraph carrying the union, and add the four filterable screens neither copy listed (security groups, CloudWatch alarms, CloudTrail events, KMS keys) so the coverage list matches the filterTarget constants actually wired to activateFilter. Closes #317 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P2bi5Xga4wU5hDPgNPd4mv
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This documentation change correctly addresses the duplicate paragraph issue. The consolidated paragraph now includes all filterable screens from both original copies plus the four additional screens (security groups, CloudWatch alarms, CloudTrail events, KMS keys) that were missing from both. The change is accurate, improves documentation quality, and has no runtime impact. Ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
YoungJinJung
left a comment
There was a problem hiding this comment.
Reviewed head: 732e7ae
Low
README.md:476— The consolidated “Filtering is currently available…” list is still incomplete. At this head, the EC2 related-resource list usesfilterEC2BrowserRelated(internal/app/screen_ec2_browser.go:196and:208) and the Inspector checklist picker usesfilterInspectorChecklistFiles(internal/app/screen_inspector.go:470and:482); both render the shared filter with inline match highlighting, just like the screens named here. The authoritative coverage list therefore still hides supported filtering from users. Add these screens (for example, “EC2 inventory instances/related resources” and “Inspector checklist files”), or explicitly scope the sentence to exclude nested and picker screens.
Summary
README.mdcarried the service-list filtering paragraph twice in a row (lines 476–477 ondbee17a). This was fallout from the browser PR merges — each merge resolved the paragraph against a different base, and one round left both copies in place.Neither copy was complete:
Changes
The additions were verified against the code, not guessed — each has both an
activateFilter(<target>)and anupdateSharedFilter(msg, <target>)call site, same as every other entry in the list.Validation
go build ./...go test ./...— all packages passgrep -c 'The service list defaults to favorites first' README.md→1README.mdfor other duplicated long lines — noneDocumentation only; no runtime behaviour changes.
Closes #317