Fix cuRobo planner example startup - #429
Merged
Merged
Conversation
Default the standalone example to one environment and build the simulation headlessly before opening the viewer after robot and obstacle setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the standalone cuRobo planner example startup by defaulting
num_envsto one when no Gym configuration merge occurs. It also builds the simulation in headless mode first and opens the interactive viewer only after the robot and obstacles are loaded and placed at their final initial poses.This prevents the example from raising a
TypeErrorwhen--num_envsis omitted and avoids opening the viewer before scene setup is complete.Dependencies: None.
Issue: N/A (reported directly; no linked GitHub issue).
Type of change
Screenshots
Not applicable.
Testing
black .black --check --diff --color ./pytest tests/sim/planners/test_curobo_planner.py(31 passed, 3 skipped)pytest tests(772 passed, 103 skipped)Checklist
black .command to format the code base.