feat(expert-program): configure semantic action options - #503
Closed
yuecideng wants to merge 1 commit into
Closed
Conversation
This was referenced Aug 11, 2026
yuecideng
marked this pull request as ready for review
August 11, 2026 16:46
Greptile SummaryThe PR moves typed semantic action options into immutable, versioned skill presets and makes integration validate that each reachable semantic call has an exact compatible template.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issue identified. Template ownership, validation, copying, compiler grounding, preset reconstruction, task configuration, and repository lowerer implementations are consistently migrated across the changed paths.
|
| Filename | Overview |
|---|---|
| embodichain/lab/sim/skills/profiles.py | Adds immutable action-option template ownership, snapshot validation, and version-2 preset construction. |
| embodichain/lab/sim/skills/integration.py | Validates template call IDs, exact option types, reserved compiler-owned fields, and selected-preset reachability. |
| embodichain/lab/sim/skills/compiler.py | Grounds built-in and registered semantic calls from preset-owned option templates while preserving compiler-owned dynamic fields. |
| embodichain/lab/gym/envs/expert_program/catalog.py | Preserves action templates during cadence alignment and includes them in the updated registration fingerprint schema. |
| embodichain/lab/gym/envs/expert_program/simulation_environment.py | Preserves option templates when rebuilding presets with the environment control cadence. |
| embodichain_tasks/embodichain_tasks/multi_segments/cube_pick_place.py | Configures typed pickup and placement options in the task's safe preset. |
| embodichain_tasks/embodichain_tasks/tableware/open_drawer.py | Configures typed articulation-operation options in the task's safe preset. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
P[SkillPolicyPreset option templates] --> V[Static integration validation]
C[Semantic call] --> V
V --> B[Bound semantic call]
B --> G[Semantic compiler grounding]
O[Planning observation] --> G
G --> I[ActionInvocation with owned options snapshot]
I --> E[Atomic action engine]
Reviews (1): Last reviewed commit: "feat(expert-program): configure semantic..." | Re-trigger Greptile
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack
feat/expert-program-presim-catalogLet immutable, versioned skill presets own typed per-action planning options in addition to motion, tracking, and recovery policies. The compiler selects and snapshots options by semantic skill rather than requiring task code to construct atomic-action option objects.
Profiles validate option types and preset reachability during integration, keeping tuning embodiment-owned and configuration-selectable.
Refs #471
Refs #474
Type of change
Screenshots
Not applicable.
Validation
tests/sim/skills/test_profiles.py,test_integration.py,test_compiler.py, and Expert Program simulation testsChecklist