Skip to content

Conversation

@adnasa
Copy link
Member

@adnasa adnasa commented Apr 4, 2018

  • adds prettier
  • updates eslint
  • uses prop-types

Now, I understand that this PR can be really noisy with 2.8K additions, but it's mostly a scroll through PR, except take note of these changes


next up (another PR)

  • upgrade babel
  • upgrade webpack

QA

check out this branch, and try out the following

  • yarn install && yarn lint && yarn build (additional run a prod build)
  • yarn dev

Running the commands above, and dext is still up and running (locally at least 😉 )

@adnasa adnasa requested a review from vutran April 4, 2018 23:49
@adnasa adnasa self-assigned this Apr 4, 2018
@vutran
Copy link
Member

vutran commented Apr 5, 2018

I think we can just ditch eslint and let prettier handle reformatting overall. No need for linting anymore unless we want to enforce specific rulesets.

@vutran
Copy link
Member

vutran commented Apr 5, 2018

Aside from that LGTM.

@vutran
Copy link
Member

vutran commented Apr 5, 2018

I added the travis project since the repo was moved. Coveralls still not updating their cache to let me add from org account so it won't report correctly.

@adnasa
Copy link
Member Author

adnasa commented Apr 5, 2018

aight let's do this 🚀

@adnasa adnasa merged commit 92e0cd3 into develop Apr 5, 2018
@adnasa adnasa deleted the aa-prettier-eslint branch April 5, 2018 15:58
@adnasa
Copy link
Member Author

adnasa commented Apr 5, 2018

@vutran

btw, I forgot to reply you on this point

I think we can just ditch eslint and let prettier handle reformatting overall. No need for linting anymore unless we want to enforce specific rulesets.

Actually, I would keep linting, since eslint-plugin-react offers rules that discourages usage of this.setState e.g in render. I wouldn't want to review code that contains this kind of mistakes :)

@vutran
Copy link
Member

vutran commented Apr 6, 2018

Actually, I would keep linting, since eslint-plugin-react offers rules that discourages usage of this.setState e.g in render. I wouldn't want to review code that contains this kind of mistakes :)

Awesome! Once we move to lerna, perhaps an eslint dext plugin would be good. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants