Skip to content

Replace latex2sympy's process_sympy with sympy's parse_latex#348

Merged
willfurnass merged 2 commits intomasterfrom
sympy_latex_parsing
Sep 23, 2019
Merged

Replace latex2sympy's process_sympy with sympy's parse_latex#348
willfurnass merged 2 commits intomasterfrom
sympy_latex_parsing

Conversation

@willfurnass
Copy link
Copy Markdown
Collaborator

Will hopefully address #300

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 20, 2019

Codecov Report

Merging #348 into master will increase coverage by 0.07%.
The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   68.88%   68.95%   +0.07%     
==========================================
  Files           9        9              
  Lines        5765     5766       +1     
  Branches     1572     1572              
==========================================
+ Hits         3971     3976       +5     
+ Misses       1399     1397       -2     
+ Partials      395      393       -2
Impacted Files Coverage Δ
mumot/consts.py 100% <100%> (ø) ⬆️
mumot/__init__.py 84.61% <100%> (ø) ⬆️
mumot/utils.py 67.7% <100%> (ø) ⬆️
mumot/views.py 66.2% <71.42%> (ø) ⬆️
mumot/models.py 71.98% <77.77%> (+0.02%) ⬆️
mumot/controllers.py 78.2% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1679c57...ef088fd. Read the comment docs.

@jarmarshall
Copy link
Copy Markdown
Contributor

I've reviewed the changes, the tests are all passed, this seems good to me. Good to unpin antlr4-python3-runtime (see issue sympy/sympy#17629)... you flagged this as work in progress @willfurnass - any reason not to merge?

@willfurnass willfurnass changed the title Replace latex2sympy's process_sympy with sympy's parse_latex (WIP) Replace latex2sympy's process_sympy with sympy's parse_latex Sep 23, 2019
@willfurnass willfurnass merged commit 8dcd2c3 into master Sep 23, 2019
@willfurnass willfurnass deleted the sympy_latex_parsing branch September 23, 2019 09:01
@willfurnass
Copy link
Copy Markdown
Collaborator Author

I've renamed and merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants