Skip to content

Fix incorrect loader auto param validation - #98

Merged
yousefmoazzam merged 3 commits into
mainfrom
fix-incorrect-loader-auto-param-validation
Mar 6, 2026
Merged

Fix incorrect loader auto param validation#98
yousefmoazzam merged 3 commits into
mainfrom
fix-incorrect-loader-auto-param-validation

Conversation

@yousefmoazzam

Copy link
Copy Markdown
Collaborator

No description provided.

…assed

The warning implies that if any input fields are empty, then job
submission will still work via using default values wherever a value was
omitted. However, job submission doesn't work in this case; instead,
validation fails and error messages are shown which inform which
parameter(s) failed validation.

Default values being inserted may be added in the future so this warning
box could be brought back. However, in the app's current state, this
warning is confusing due to it saying something will happen when it
won't, so it is being removed for now.
@yousefmoazzam
yousefmoazzam marked this pull request as ready for review March 6, 2026 16:50
@yousefmoazzam
yousefmoazzam merged commit 1bc40ef into main Mar 6, 2026
1 check passed
@yousefmoazzam
yousefmoazzam deleted the fix-incorrect-loader-auto-param-validation branch March 6, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant