Skip to content

LIMS-91: Load sample image if specified in URL#890

Merged
ndg63276 merged 1 commit intopre-release/2025-R2.3from
fix/LIMS-91/load-current-sample-image
Apr 8, 2025
Merged

LIMS-91: Load sample image if specified in URL#890
ndg63276 merged 1 commit intopre-release/2025-R2.3from
fix/LIMS-91/load-current-sample-image

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jan 8, 2025

JIRA ticket: LIMS-91
JIRA ticket: LIMS-523

Summary:

If you go to a URL like /containers/cid/317254/iid/152920/sid/6049306, although the correct container (317254) and inspection (152920) are loaded, the sample (6049306) is not.
Also, caching the sample images is unnecessary with modern internet speeds.

Changes:

  • Remove the preCache function and related variables
  • Convert the sample id to a string before comparing to samples in the model

To test:

  • Go to a proposal with plates (eg nt37104), then go to a container (eg /containers/cid/317254)
  • Check images are not being cached but are still loaded when you click on a well on the plate
  • Add an inspection id to the end of the URL, eg /iid/152920. Check the Inspections dropdown is showing the correct inspection (in this case, from 11/11/2024).
  • Add a sample id to the end of that URL, eg /sid/6049306. Check the correct well from the plate is shown, in this case well 35.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R2.3 April 8, 2025 10:42
@ndg63276 ndg63276 merged commit f50ce49 into pre-release/2025-R2.3 Apr 8, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-91/load-current-sample-image branch April 8, 2025 11:18
ndg63276 added a commit that referenced this pull request Apr 22, 2025
* LIMS-995: Fix Shipment Stats page (#915)

* LIMS-91: Load sample image if specified in URL (#890)

* LIMS-1238: Speed up query to list persons on visit (#886)

* LIMS-1615: Allow direct links to visit summary page (#902)

* LIMS-42: Minor speedup of _get_all_containers (#885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants