Skip to content

LIMS-1615: Allow direct links to visit summary page#902

Merged
ndg63276 merged 1 commit intopre-release/2025-R2.3from
fix/LIMS-1615/allow-direct-link-to-summary-page
Apr 8, 2025
Merged

LIMS-1615: Allow direct links to visit summary page#902
ndg63276 merged 1 commit intopre-release/2025-R2.3from
fix/LIMS-1615/allow-direct-link-to-summary-page

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Feb 6, 2025

JIRA ticket: LIMS-1615

Summary:

Links to eg https://ispyb.diamond.ac.uk/dc/summary/visit/cm40608-1 don't work, as the proposal is not set.

Changes:

  • Set the proposal 'cookie' when navigating to the page. This is reverting commit 80ef089.

To test:

  • In a new browser tab for each, go to /dc/summary/visit/cm40608-1, /dc/apstatussummary/visit/cm40608-1, /dc/sc/visit/cm40608-1 and /dc/visit/cm40608-1 and check each one loads correctly, with the proposal set.
  • Try again, but log in as someone without permission to view that visit, check each page doesn't load

@gfrn
Copy link
Collaborator

gfrn commented Feb 14, 2025

Looks good to me!

Unintended feature (?): if you go to /dc/summary/visit/cm40608-1/dc/summary/visit/cm40608-1, it takes you to the data collection page

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R2.3 April 8, 2025 10:42
@ndg63276 ndg63276 merged commit 11fdaf3 into pre-release/2025-R2.3 Apr 8, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1615/allow-direct-link-to-summary-page branch April 8, 2025 11:19
ndg63276 added a commit that referenced this pull request Apr 22, 2025
* LIMS-995: Fix Shipment Stats page (#915)

* LIMS-91: Load sample image if specified in URL (#890)

* LIMS-1238: Speed up query to list persons on visit (#886)

* LIMS-1615: Allow direct links to visit summary page (#902)

* LIMS-42: Minor speedup of _get_all_containers (#885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants