LIMS-1648: Only display auto proc program attachment files where deleted column is 0#921
Merged
ndg63276 merged 19 commits intopre-release/2025-R2.5from May 6, 2025
Conversation
…ved text" in deleted !== "0"
…vailable through app.options in front-end
…cProgramAttachement-files-where-deleted-column-is-0
ndg63276
changed the title
…& isIndustry status
ndg63276
reviewed
Apr 28, 2025
ndg63276
reviewed
Apr 28, 2025
ndg63276
reviewed
Apr 28, 2025
ndg63276
reviewed
Apr 28, 2025
Collaborator
ndg63276
left a comment
ndg63276
left a comment
There was a problem hiding this comment.
Just a couple of nitpicks, but otherwise looks good, and it all seems to work well!
ndg63276
deleted the
improvement/LIMS-1648/Only-display-AutoProcProgramAttachement-files-where-deleted-column-is-0
branch
ndg63276
added a commit
that referenced
this pull request
May 27, 2025
* LIMS-1648: Only display auto proc program attachment files where deleted column is 0 (#921) * LIMS-1400: Remove logon stats page (#916) * LIMS-1702: Rename Archive button to Download Zip (#930) * LIMS-1719: Fix data collection comments button (#931) * LIMS-1694: Allow beamlines to disable user assignment of pucks (#925) * LIMS-1687: Remove references to GridInfo.pixelsPerMicronX/Y (#926)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 1648 - Only display AutoProcProgramAttachement files where deleted column is 0
JIRA ticket: TICKET-1648
and by extension TICKET-1685
Summary:
Due to future plans for the removal of files from the fs after a certain period, Synchweb should use the BLSession.purgedProcessedData column to assess whether the files for a session have been removed or remain available to download. If a file has been removed from the FS it should present an iCat Link pointing (for the time being) at the project root in iCat. Note that industry proposals will always show 'Deleted' instead.
This iCat link should be amendable in the config.php file.
The exception are any files registered with APPAttachment.filePath containing the string listed in config.php $visit_persist_storage_dir_segment. These are never deleted and should therefore should display their download button even when the visit/BLSession is registered as "purged".
Changes:
To test:
Reference Example:
Purged Session setup:
Non-industry proposal:
$visit_persist_storage_dir_segmentinconfig.phpshould retain its download/view buttons.industry proposal:
$visit_persist_storage_dir_segmentinconfig.phpshould retain its download/view buttons.Config.php Amendments
iCatURL config (non-industry ONLY):
$icat_base_urlis not set inconfig.phpthen nothing should be shown.persistent storage (BOTH):
$visit_persist_storage_dir_segmentis not set inconfig.phpand a session has been purged then all attachments will show removed OR icat link