LIMS-1687: Remove references to GridInfo.pixelsPerMicronX/Y#926
Merged
ndg63276 merged 3 commits intopre-release/2025-R2.5from May 6, 2025
Merged
Conversation
Collaborator
|
Is it worth updating |
Collaborator
Author
Good plan, I think that's all the references in api/docs/ |
gfrn
approved these changes
Apr 28, 2025
…e-refs-to-pixelsPerMicron
ndg63276
added a commit
that referenced
this pull request
May 27, 2025
* LIMS-1648: Only display auto proc program attachment files where deleted column is 0 (#921) * LIMS-1400: Remove logon stats page (#916) * LIMS-1702: Rename Archive button to Download Zip (#930) * LIMS-1719: Fix data collection comments button (#931) * LIMS-1694: Allow beamlines to disable user assignment of pucks (#925) * LIMS-1687: Remove references to GridInfo.pixelsPerMicronX/Y (#926)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1687
Summary:
A couple of years ago we discovered we had been confusing pixelsPerMicron and micronsPerPixel. We have now committed to only populating micronsPerPixel, and all values from pixelsPerMicron have been copied over. PR #517 was used to prefer micronsPerPixel, with a fallback to pixelsPerMicron. This PR is to remove that fallback as it is no longer necessary.
Changes:
GridInfo.micronsPerPixelXandGridInfo.micronsPerPixelYdirectly, without the IFNULL fallback.To test: