Skip to content

LIMS-1713: Allow sm beamlines to use mx Create Container page#932

Merged
ndg63276 merged 1 commit intopre-release/2025-R3.1from
improvement/LIMS-1713/let-sm-beamlines-use-mx-create-container-page
May 27, 2025
Merged

LIMS-1713: Allow sm beamlines to use mx Create Container page#932
ndg63276 merged 1 commit intopre-release/2025-R3.1from
improvement/LIMS-1713/let-sm-beamlines-use-mx-create-container-page

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented May 2, 2025

JIRA ticket: LIMS-1713

Summary:

I19 is the only small molecule ('sm') beamline at Diamond, and they would rather use the 'mx' Create Container and View Container pages, as we sometimes break their versions.

Changes:

  • Add sm to the container maps and point them the same as mx

To test:

  • Check you have something like this in your config:
$bl_types = array(
    array('name' => 'i03', 'group' => 'mx', 'logbook' => 'BLI03' ),
    array('name' => 'i04', 'group' => 'mx', 'logbook' => 'BLI04' ),
    array('name' => 'i04-1', 'group' => 'mx', 'logbook' => 'BLI04J' ),
    array('name' => 'i23', 'group' => 'mx', 'logbook' => 'BLI23' ),
    array('name' => 'i24', 'group' => 'mx', 'logbook' => 'BLI24' ),
    array('name' => 'i22', 'group' => 'saxs', 'logbook' => 'BLI22' ),
    array('name' => 'i19', 'group' => 'sm', 'logbook' => 'BLI19' ),
    array('name' => 'i19-1', 'group' => 'sm' ),
    array('name' => 'i19-2', 'group' => 'sm' ),
    array('name' => 'i15', 'group' => 'xpdf', 'logbook' => 'BLI15' ),
    array('name' => 'i15-1', 'group' => 'xpdf' ),
);
  • Go to an i19-1 proposal, eg cm40638, go to a shipment and click Add Container. Check you get directed to the MX view with 3 tabs (Basic, Extra Fields and UDC).
  • Create the puck and then click to view it. Check all the samples are displayed and any parameters you filled in are also displayed. Check you can edit the samples.
  • Repeat the test for an mx proposal eg mx23694
  • Repeat the test for an xpdf proposal eg cm40633, check you still get redirected to the "Add new Sample Stage" page
  • Repeat the test for a saxs proposal eg cm40643, check you still get redirected to the old "Add new container" page with no tabs.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.1 May 27, 2025 09:33
@ndg63276 ndg63276 merged commit 2bcfab3 into pre-release/2025-R3.1 May 27, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1713/let-sm-beamlines-use-mx-create-container-page branch May 27, 2025 09:34
ndg63276 added a commit that referenced this pull request Jun 10, 2025
* LIMS-1447: Don't allow shipping of red samples (#929)

* LIMS-1664: Improvements to registered dewar and container pages (#927)

* LIMS-1636: Make LDAP server ID field configurable (#934)

* LIMS-1699: Show confirmation dialog if a user creates a plate that is not full (#924)

* LIMS-1713: Allow sm beamlines to use mx Create Container page (#932)

* LIMS-1770: Fix download of attachments on saxs and xpdf beamlines (#944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants