[LIMS-1636] Make LDAP server ID field configurable#934
Merged
ndg63276 merged 2 commits intopre-release/2025-R3.1from May 27, 2025
Merged
[LIMS-1636] Make LDAP server ID field configurable#934ndg63276 merged 2 commits intopre-release/2025-R3.1from
ndg63276 merged 2 commits intopre-release/2025-R3.1from
Conversation
gfrn
added
enhancement
php
ndg63276
added a commit
that referenced
this pull request
Jun 10, 2025
* LIMS-1447: Don't allow shipping of red samples (#929) * LIMS-1664: Improvements to registered dewar and container pages (#927) * LIMS-1636: Make LDAP server ID field configurable (#934) * LIMS-1699: Show confirmation dialog if a user creates a plate that is not full (#924) * LIMS-1713: Allow sm beamlines to use mx Create Container page (#932) * LIMS-1770: Fix download of attachments on saxs and xpdf beamlines (#944)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1636
Summary:
This PR allows users to configure which field is used to get the user ID from in LDAP, to make it easier to switch between LDAP providers.
Changes:
ldap_id_fieldconfiguration keyTo test:
mx23694, navigate to the shipments page, add a new shipmenttransferon the dewar that was just created, check if the LC email is pre-populateddispatchfor the same dewar, ensure the same is still trueemail.txt, then these emails should appear in there_get_nameto get names from LDAP, you can modify the code to call it and ensure it still works