LIMS-1739: Add button to say shipment is ready for scheduling#945
Merged
ndg63276 merged 6 commits intopre-release/2025-R3.4from Jul 8, 2025
Merged
Conversation
gfrn
reviewed
Jul 8, 2025
gfrn
reviewed
Jul 8, 2025
gfrn
reviewed
Jul 8, 2025
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
gfrn
approved these changes
Jul 8, 2025
ndg63276
added a commit
that referenced
this pull request
Jul 22, 2025
* LIMS-1501: Allow re-running downstream processing (#948) * LIMS-1501: Early work on re-running downstream processing * LIMS-1501: Flesh out re-running downtream processing * LIMS-1501: Remove unnecessary ProcessingJobParameters * LIMS-1501: Enable fast_ep and some fast_dp * LIMS-1501: Trigger zocalo directly * LIMS-1501: Rename recipes for consistency * LIMS-1501: Rename file more appropriately --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1771: Dont display zero dose on grouped collections (#951) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1688: Downstream processing wont display if filesystem not mounted (#953) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1739: Add button to say shipment is ready for scheduling (#945) * LIMS-1739: Add button to say shipment is ready for scheduling * LIMS-1739: Add button to say shipment is ready for scheduling * LIMS-1739: Add contact instruction * LIMS-1739: Dont show 'ready' button for industrial proposals * Apply suggestions from code review Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk> --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk> --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1739
Summary:
If a user has selected "I would like a session to be scheduled" when creating a shipment, it is hard to know when they have created all the dewars and pucks within the shipment. We should have a button to say "My shipment is ready for scheduling". When the user has pressed this button, we should disable creating new dewars and pucks.
Changes:
To test: