Skip to content

LIMS-1688: Downstream processing wont display if filesystem not mounted#953

Merged
ndg63276 merged 1 commit intopre-release/2025-R3.4from
fix/LIMS-1688/downstream-processing-wont-display-if-filesystem-not-mounted
Jul 8, 2025
Merged

LIMS-1688: Downstream processing wont display if filesystem not mounted#953
ndg63276 merged 1 commit intopre-release/2025-R3.4from
fix/LIMS-1688/downstream-processing-wont-display-if-filesystem-not-mounted

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jul 1, 2025

JIRA ticket: LIMS-1688

Summary:

If the filesystem with FastEP results on is not mounted, (or we cannot get the files for some reason), the whole downstream processing bar won't display.

Changes:

  • Prepopulate the results data with error messages, that will be overwritten when results are found
  • Check there is plotting data returned before attempting to plot a graph

To test:

  • Start a synchweb instance on a machine without /dls/ mounted
  • Go to a data collection with FastEP results, eg /dc/visit/cm40607-3/id/18552850
  • Click on Downstream Processing, check it expands to show results
  • Click on FastEP, check it displays that the files are not found, and no graph is displayed
  • Mount /dls and refresh the page
  • Check there are now results for FOM and CC, atoms listed with coordinates and occupancy, and a graph is displayed

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.4 July 8, 2025 10:29
@ndg63276 ndg63276 merged commit 6d584df into pre-release/2025-R3.4 Jul 8, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1688/downstream-processing-wont-display-if-filesystem-not-mounted branch July 8, 2025 10:30
ndg63276 added a commit that referenced this pull request Jul 22, 2025
* LIMS-1501: Allow re-running downstream processing (#948)

* LIMS-1501: Early work on re-running downstream processing

* LIMS-1501: Flesh out re-running downtream processing

* LIMS-1501: Remove unnecessary ProcessingJobParameters

* LIMS-1501: Enable fast_ep and some fast_dp

* LIMS-1501: Trigger zocalo directly

* LIMS-1501: Rename recipes for consistency

* LIMS-1501: Rename file more appropriately

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1771: Dont display zero dose on grouped collections (#951)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1688: Downstream processing wont display if filesystem not mounted (#953)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1739: Add button to say shipment is ready for scheduling (#945)

* LIMS-1739: Add button to say shipment is ready for scheduling

* LIMS-1739: Add button to say shipment is ready for scheduling

* LIMS-1739: Add contact instruction

* LIMS-1739: Dont show 'ready' button for industrial proposals

* Apply suggestions from code review

Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants