Skip to content

fix: get tasks endpoint to a enum#1578

Merged
ZohebShaikh merged 7 commits into
mainfrom
add-enum-for-endpoint
Jul 3, 2026
Merged

fix: get tasks endpoint to a enum#1578
ZohebShaikh merged 7 commits into
mainfrom
add-enum-for-endpoint

Conversation

@ZohebShaikh

Copy link
Copy Markdown
Contributor

Currently get_tasks takes a string to filter on task_status, but it should be a enum.

@ZohebShaikh ZohebShaikh requested a review from a team as a code owner June 30, 2026 07:05
@ZohebShaikh ZohebShaikh force-pushed the add-enum-for-endpoint branch from 075e64b to ba64006 Compare June 30, 2026 07:08
@ZohebShaikh ZohebShaikh force-pushed the add-enum-for-endpoint branch from ba64006 to a5fbf0a Compare June 30, 2026 07:23
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.91%. Comparing base (4c5b567) to head (5232dc8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
- Coverage   95.93%   95.91%   -0.03%     
==========================================
  Files          44       44              
  Lines        3271     3254      -17     
==========================================
- Hits         3138     3121      -17     
  Misses        133      133              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/blueapi/service/main.py Outdated
@ZohebShaikh ZohebShaikh requested a review from tpoliaw July 3, 2026 09:56

@tpoliaw tpoliaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave name decision to you. I think this is an improvement already

Comment thread src/blueapi/service/interface.py Outdated
@ZohebShaikh ZohebShaikh added this pull request to the merge queue Jul 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 3, 2026
@ZohebShaikh ZohebShaikh added this pull request to the merge queue Jul 3, 2026
Merged via the queue into main with commit 0ea80d0 Jul 3, 2026
20 checks passed
@ZohebShaikh ZohebShaikh deleted the add-enum-for-endpoint branch July 3, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants