Skip to content

Update adsim to functional format#204

Merged
abbiemery merged 4 commits intomainfrom
startup_scripts
May 16, 2023
Merged

Update adsim to functional format#204
abbiemery merged 4 commits intomainfrom
startup_scripts

Conversation

@abbiemery
Copy link
Copy Markdown
Contributor

Fixes #201

@abbiemery abbiemery requested a review from joeshannon May 16, 2023 10:50
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2023

Codecov Report

Merging #204 (87965d4) into main (a90b53b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files          41       41           
  Lines        1120     1120           
=======================================
  Hits          980      980           
  Misses        140      140           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also switch to using the adsim module in dodal now?

@abbiemery
Copy link
Copy Markdown
Contributor Author

@callumforrester I've now removed it and just changed the yaml to use dodal.

@abbiemery abbiemery merged commit eb497fc into main May 16, 2023
@abbiemery abbiemery deleted the startup_scripts branch May 16, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change ADSim and simmotor startup scrips to the new dodal format

2 participants