PySIMRecon service message bug fixes - #291
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 83.06% 83.09% +0.03%
==========================================
Files 76 76
Lines 9581 9584 +3
Branches 1289 1289
==========================================
+ Hits 7958 7964 +6
+ Misses 1120 1117 -3
Partials 503 503 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
August 5, 2026 08:17
tieneupin
changed the title
stephen-riggs
approved these changes
Aug 6, 2026
stephen-riggs
left a comment
stephen-riggs
left a comment
Contributor
There was a problem hiding this comment.
Looks fine, but note Dan's comment about the default values
…added an explanation for the default values used by PySIMRecon
tieneupin
force-pushed
the
pysimrecon-message-fixes
branch
from
August 7, 2026 02:55
0032b2d to
f0aacd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further updates to the PySIMRecon service's Pydantic model:
SIMOTFParametersandSIMReconParametersas default fields inPySIMReconParameters. This will allow us to (eventually) pass in values from Murfey.