Enable converting display types for Quick Screens - #222
Merged
Conversation
niamhdougan
approved these changes
Jul 23, 2026
niamhdougan
left a comment
niamhdougan
left a comment
Collaborator
There was a problem hiding this comment.
As discussed:
- we probably don't want quick screen conversion from the top synoptic view
- quick screen menu buttons are staggeredly stacked when browser expanded on ultrawide monitor
otherwise works well :)
Collaborator
Author
|
I'll include those fixes on the Daedalus side branch for these changes, thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the functionality to convert a loaded file from one type to another. This can mostly be used for loading .bob files as quick screen type displays. If a string containing the type to convert to is passed into a DynamicPage/EmbeddedDisplay, the file contents are modified to add quick screen properties.
Also added tests to support this. Can test using branch convert-quick-screens on Daedalus.