I15-1: Allow specifying an attenuation per each point on the PDF - #201
Merged
Conversation
jacob-williamson
approved these changes
Sep 7, 2026
jacob-williamson
left a comment
jacob-williamson
left a comment
Collaborator
There was a problem hiding this comment.
Looks good thanks, one suggestion, take it or leave it
| @field_validator("transmission") | ||
| @classmethod | ||
| def _validate_transmission(cls, transmission: float) -> float: | ||
| allowed_transmissions = [100, 50, 10, 1, 0.1, 0.01, 0.001] |
Collaborator
There was a problem hiding this comment.
I'm guessing these always match these, if possible could we define them in one place? Might be tricky as we don't want the config server depending on ophyd-async for StrictEnum
Collaborator
Author
There was a problem hiding this comment.
Yh, they are. I did think about trying to map them in someway but like you said, I'm not sure where it would naturally live. I will sleep on it
Collaborator
Author
There was a problem hiding this comment.
Discussed in person, we will just validate in dodal, not here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DiamondLightSource/crystallography-bluesky#127
Note:
collection_specification.jsonon disk has not yet been updated, will do so once this is releasedTo test: