Hla 966 validation regexes#47
Merged
Merged
Conversation
As part of this, the regexes used for finding module versions have also been fixed. It would previously exclude any versions using any characters in ".version", rather than excluding only the whole string
With the use of large JSON objects for storing configuration, these error messages are otherwise too cluttered to be useful.
ContainerImage.version will be renamed to tag in a later release. For now, we will keep the interface identical.
This is restrictive, but currently supports all existing modules in use at Diamond.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 76.43% 76.69% +0.25%
==========================================
Files 24 25 +1
Lines 904 914 +10
==========================================
+ Hits 691 701 +10
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Looks good, the regexes seem sensible and give us a clean structure to work with should we need to make any changes when it goes live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation regexes for as many fields as possible.
For the most part, I have been permissive where possible as we assume that people are not trying to break the system.
I will try to add validation for URLs, but that is better off in a separate PR as I need to change and test how the schema is generated and yaml is processed.