846 device factory support for ophyd v1#984
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
+ Coverage 97.57% 97.59% +0.01%
==========================================
Files 154 154
Lines 6445 6448 +3
==========================================
+ Hits 6289 6293 +4
+ Misses 156 155 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 13, 2025
callumforrester
suggested changes
Jan 13, 2025
|
|
||
|
|
||
| class DeviceInitializationController(Generic[D]): | ||
| class DeviceInitializationController(Generic[T]): |
Contributor
There was a problem hiding this comment.
Does D have any other uses? If not it should be deleted
| if is_v2_device: | ||
| device: T = self._factory(**kwargs) | ||
| else: | ||
| device: T = self._factory(mock=is_mock, **kwargs) |
Contributor
There was a problem hiding this comment.
Do we have tests that cover this and the other else parts?
This was referenced Jan 13, 2025
rtuck99
force-pushed
the
846_update_mx_beamlines_to_use_device_factory
branch
3 times, most recently
from
d6fa71e to
e52f976
Compare
rtuck99
force-pushed
the
846_device_factory_support_for_ophyd_v1
branch
from
333ec5b to
69a37be
Compare
Base automatically changed from
846_update_mx_beamlines_to_use_device_factory
to
main
January 29, 2025 15:18
rtuck99
force-pushed
the
846_device_factory_support_for_ophyd_v1
branch
from
69a37be to
1b12cef
Compare
rtuck99
force-pushed
the
846_device_factory_support_for_ophyd_v1
branch
from
1b12cef to
709df01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #846
Builds on top of and was previously part of
This PR adds support for Ophyd v1 to the
device_factory, and migrates the i03eiger,s4_slit_gapsandfluxdevices to thedevice_factorySee also mx-bluesky PR
Instructions to reviewer on how to test:
dodal connect i03 worksChecks for reviewer
dodal connect ${BEAMLINE}