Skip to content

Convert i23 to use device factory#987

Merged
DominicOram merged 3 commits intomainfrom
846_convert_i23_to_use_device_factory
Feb 19, 2025
Merged

Convert i23 to use device factory#987
DominicOram merged 3 commits intomainfrom
846_convert_i23_to_use_device_factory

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jan 13, 2025

Part of a series of PRs that addresses

This PR migrates i23 to use the device_factory decorator and builds on

Instructions to reviewer on how to test:

  1. dodal connect i23 succeeds

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@rtuck99 rtuck99 requested a review from a team as a code owner January 13, 2025 17:12
@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (a200381) to head (34493fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files         160      160              
  Lines        6632     6629       -3     
==========================================
- Hits         6479     6476       -3     
  Misses        153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtuck99 rtuck99 force-pushed the 846_device_factory_support_for_ophyd_v1 branch 3 times, most recently from 1b12cef to 709df01 Compare January 29, 2025 16:34
@rtuck99 rtuck99 force-pushed the 846_convert_i23_to_use_device_factory branch from 456f40a to 8bbc2c9 Compare January 30, 2025 09:38
@rtuck99 rtuck99 changed the base branch from 846_device_factory_support_for_ophyd_v1 to main January 30, 2025 09:38
@rtuck99 rtuck99 force-pushed the 846_convert_i23_to_use_device_factory branch from 8bbc2c9 to 271277e Compare January 30, 2025 10:12
@rtuck99 rtuck99 force-pushed the 846_convert_i23_to_use_device_factory branch from 271277e to 7368028 Compare January 30, 2025 10:34
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram DominicOram merged commit 4ca1dc0 into main Feb 19, 2025
18 of 19 checks passed
@DominicOram DominicOram deleted the 846_convert_i23_to_use_device_factory branch February 19, 2025 09:56
@DominicOram DominicOram changed the title 846 convert i23 to use device factory Convert i23 to use device factory Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants