Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
==========================================
- Coverage 97.69% 97.69% -0.01%
==========================================
Files 160 160
Lines 6632 6629 -3
==========================================
- Hits 6479 6476 -3
Misses 153 153 ☔ View full report in Codecov by Sentry. |
1b12cef to
709df01
Compare
456f40a to
8bbc2c9
Compare
8bbc2c9 to
271277e
Compare
271277e to
7368028
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series of PRs that addresses
This PR migrates i23 to use the
device_factorydecorator and builds on846 device factory support for ophyd v1 #984Instructions to reviewer on how to test:
dodal connect i23succeedsChecks for reviewer
dodal connect ${BEAMLINE}