Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## groups #29 +/- ##
==========================================
- Coverage 39.03% 38.07% -0.96%
==========================================
Files 4 4
Lines 228 239 +11
==========================================
+ Hits 89 91 +2
- Misses 139 148 +9 ☔ View full report in Codecov by Sentry. |
TBThomas56
approved these changes
Apr 3, 2024
Contributor
TBThomas56
left a comment
TBThomas56
left a comment
There was a problem hiding this comment.
Makes sense. Code improves error handling and covers more edge cases in the parameter data type and ignored parameters
TBThomas56
approved these changes
Apr 4, 2024
jsouter
reviewed
Apr 5, 2024
jsouter
approved these changes
Apr 5, 2024
Contributor
jsouter
left a comment
jsouter
left a comment
There was a problem hiding this comment.
Looks good, though of course would be good to address the TODOs before this eventually goes into main
The simulator needs to be updated to respond without this nesting.
Improve error message for unhandled parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes made to enable running against a real detector
Fixes #17
Fixes #20