Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 39.03% 43.29% +4.25%
==========================================
Files 4 4
Lines 228 261 +33
==========================================
+ Hits 89 113 +24
- Misses 139 148 +9 ☔ View full report in Codecov by Sentry. |
4bf7cba to
43d84c7
Compare
jsouter
approved these changes
Apr 5, 2024
e824900 to
a9645b2
Compare
43d84c7 to
88f92a2
Compare
88f92a2 to
1a04a28
Compare
Add EigerParameter class. Separate initialize into logical steps: - Send requests to detector - Handle key clashes - Create attributes This removes the limitation that key clashes are only handled between adjacent subsystems.
1a04a28 to
9affc2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate initialize into logical steps:
This removes the limitation that key clashes are only handled between adjacent subsystems.