Skip to content

Refactor initialize#30

Merged
GDYendell merged 1 commit intomainfrom
refactor-initialize
Apr 10, 2024
Merged

Refactor initialize#30
GDYendell merged 1 commit intomainfrom
refactor-initialize

Conversation

@GDYendell
Copy link
Contributor

@GDYendell GDYendell commented Apr 2, 2024

Separate initialize into logical steps:

  • Send requests to detector
  • Handle key clashes
  • Create attributes

This removes the limitation that key clashes are only handled between adjacent subsystems.

@GDYendell GDYendell changed the base branch from main to api-fixes April 2, 2024 12:28
@codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 32.05128% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 43.29%. Comparing base (bb8e27e) to head (4bf7cba).
Report is 7 commits behind head on main.

❗ Current head 4bf7cba differs from pull request most recent head 9affc2b. Consider uploading reports for the commit 9affc2b to get more accurate results

Files Patch % Lines
src/eiger_fastcs/eiger_controller.py 34.84% 43 Missing ⚠️
src/eiger_fastcs/http_connection.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   39.03%   43.29%   +4.25%     
==========================================
  Files           4        4              
  Lines         228      261      +33     
==========================================
+ Hits           89      113      +24     
- Misses        139      148       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GDYendell GDYendell force-pushed the refactor-initialize branch 2 times, most recently from 4bf7cba to 43d84c7 Compare April 2, 2024 12:31
@GDYendell GDYendell requested a review from jsouter April 4, 2024 14:49
@GDYendell GDYendell force-pushed the api-fixes branch 2 times, most recently from e824900 to a9645b2 Compare April 10, 2024 11:13
@GDYendell GDYendell force-pushed the refactor-initialize branch from 43d84c7 to 88f92a2 Compare April 10, 2024 11:14
Base automatically changed from api-fixes to main April 10, 2024 12:04
@GDYendell GDYendell force-pushed the refactor-initialize branch from 88f92a2 to 1a04a28 Compare April 10, 2024 12:05
Add EigerParameter class.
Separate initialize into logical steps:
  - Send requests to detector
  - Handle key clashes
  - Create attributes

This removes the limitation that key clashes are only handled between
adjacent subsystems.
@GDYendell GDYendell force-pushed the refactor-initialize branch from 1a04a28 to 9affc2b Compare April 10, 2024 12:13
@GDYendell GDYendell merged commit c5de4f0 into main Apr 10, 2024
@GDYendell GDYendell deleted the refactor-initialize branch April 10, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants