Enable sweep runs over paganin filter to use hdf5 file as backing - #736
Merged
Conversation
There's enough common code across the hdf5 and RAM versions of the sweep writer and reader that having a single class for each of the reader and writer makes more sense than duplicating code across an hdf5 and RAM version of each of the writer and reader.
dkazanc
reviewed
Aug 4, 2026
| from httomo.preview import PreviewConfig, PreviewDimConfig | ||
| from httomo.runner.dataset_store_interfaces import DataSetSource | ||
|
|
||
| PAGANIN_SWEEP_VALUE_THRESHOLD = 50 |
Collaborator
There was a problem hiding this comment.
ah, nice touch on the threshold. I think it is reasonable to assume for now. Tested, the switch works well.
dkazanc
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IMGDA-931
Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes