Injecting distortion coefficients into the method#740
Conversation
yousefmoazzam
left a comment
There was a problem hiding this comment.
One question regarding what users would want, I'm unsure.
In the case of providing a file with the distortion coefficients, I see that the file is no longer copied into the output dir. It looks like the python dict containing the params is modified which makes sense, but the YAML copied to the output dir won't have these injected coefficients values I think. If so, it looks like there's no record in the output dir of the coefficient values used for the run if a file with the coefficient values is provided, is that correct? And if so, is that OK for users?
|
Ah, the screenshots from the original post in the PR shows the copied YAML does have the injected coefficient values, I must have just not seen it in the code! 😅 Apologies for being silly, but where is that happening? |
|
Never mind, I'm being very slow today it seems: the edited python dict is returned, and that then is copied to the output dir. Excuse my silliness... 🤣 |
|
the values extracted, inserted into the method and then copied into the |
Fixes issue, needs merging with this PR
Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes