You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
StoreInIspyb base class should become more general so that other scan types can use it
store_grid_scan should probably move out into its own thing
we should minimise any calculation of things in StoreInIpsyb or deriving classes, such as the filename - instead of things like params["file_template"] = f"{self.detector_params.prefix}_{self.run_number}_master.h5" the full filename should be known and determined by the InternalParameters - also relevant to Make nexus writer deal with different experiment types #370 now in tidy ispyb deposition code #707
StoreInIspybbase class should become more general so that other scan types can use itstore_grid_scanshould probably move out into its own thingwe should minimise any calculation of things innow in tidy ispyb deposition code #707StoreInIpsybor deriving classes, such as the filename - instead of things likeparams["file_template"] = f"{self.detector_params.prefix}_{self.run_number}_master.h5"the full filename should be known and determined by the InternalParameters - also relevant to Make nexus writer deal with different experiment types #370