This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Allow disabling stub offsets#1014
Merged
Merged
Conversation
Collaborator
Author
|
Also made #1015 to do some tidying up around the tests |
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 93.67% 93.68%
=======================================
Files 56 56
Lines 2704 2708 +4
=======================================
+ Hits 2533 2537 +4
Misses 171 171 ☔ View full report in Codecov by Sentry. |
d-perl
approved these changes
Dec 1, 2023
d-perl
left a comment
d-perl
left a comment
Contributor
There was a problem hiding this comment.
This seems fine for now - could you add a comment to the parameters issue to fix this later?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1010
Dodal PR at DiamondLightSource/dodal#251
To test:
Notes
Please also review https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/40665 at the same time
I'm not a big fan of passing this all the way down like this, especially as we have to then put it in dodal. But hopefully its a temporary measure, open to better suggestions though.