973 speed up test pin centring

[5u6in]

Fixes #973

• Identified test functions test_pin_tip_starting_near_negative_edge_doesnt_exceed_limit and test_pin_tip_starting_near_positive_edge_doesnt_exceed_limit that took the most time to run
• Created mock object and mock generator to replace call to yield from trigger_and_return_pin_tip(oav.mxsc.pin_tip) in two test functions that took the most time
• Added .side_effect to mock generators

To test:

1. Run tests in test_pin_tip_centring.py in main branch and compare how long they take with 973_speed_up_test_pin_centring branch
2. Confirm branch is faster using the Testing feature in VSCode

[olliesilvester]

Should: The return value for mock_generator gives us our tip_x and tip_y, so we should give it the same parameters as it was using before, in the sim_puts, (0,100).

[olliesilvester]

Could: We are using this function to mock out the trigger_and_return_pin_tip, and it gives us a pin_x and pin_y value. I'd name it something like get_fake_pin_values_generator instead

[olliesilvester]

Should: This variable is the patched mock for trigger_and_return_pin_tip, so mock_move_pin_into_view should be called mock_trigger_and_return_pin_tip instead

[olliesilvester]

Same comment as above for this variable name

[olliesilvester]

Nice, these tests run more than 2x faster than on main. There's just a few very minor changes I've put in the comments

[olliesilvester]

Looks good now, thanks. I'm stumped on why the CI is failing though, any ideas @dperl-dls ?

[d-perl]

@olliesilvester Just need to merge main if you want tests to pass, related to recent ispyb changes. I think it's fine to just merge this, CI will be fine in main

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (369e8da) 93.68% compared to head (fd29564) 93.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   93.68%   93.50%   -0.19%     
==========================================
  Files          56       56              
  Lines        2708     2708              
==========================================
- Hits         2537     2532       -5     
- Misses        171      176       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CI now fine

[DominicOram]

Looks good, I'm glad our tests are faster now. Thanks @subinsaji!