This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Apply ophyd-async version hotfix#1037
Merged
Merged
Conversation
noemifrisina
self-requested a review
December 12, 2023 11:08
noemifrisina
suggested changes
Dec 12, 2023
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
I think you may need to pin the dodal commit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 58 58
Lines 2774 2774
=======================================
Hits 2594 2594
Misses 180 180 ☔ View full report in Codecov by Sentry. |
noemifrisina
approved these changes
Dec 12, 2023
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
Thanks, error goes away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1028 by applying suggested hotfix. After this merge, we can unpin ophyd-async in dodal
Link to dodal PR (if required): (DiamondLightSource/dodal#262)