This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Updated zocalo message format#662
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #662 +/- ##
=======================================
Coverage 90.07% 90.07%
=======================================
Files 32 32
Lines 1420 1421 +1
=======================================
+ Hits 1279 1280 +1
Misses 141 141
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
approved these changes
May 18, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
This looks good, thank you. We should co-ordinate the merge with DiamondLightSource/python-dlstbx#215 though
Collaborator
|
Dials side merged, we should find a time to test this |
Collaborator
|
Can't test on beamline at the moment, hopefully in a couple of weeks. |
DominicOram
approved these changes
Jun 8, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
The analysis change for this is live so we should merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DiamondLightSource/python-dlstbx#215
To test: