This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Add test for writing nexus files early#680
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 34 34
Lines 1494 1494
=======================================
Hits 1341 1341
Misses 153 153 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d-perl
approved these changes
May 23, 2023
d-perl
left a comment
Contributor
There was a problem hiding this comment.
tests pass and fail as described, the skipped test previously worked for correct nexus files so that issue should fix it. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #677
To test:
pip install nexgen==0.6.26pip install nexgen==0.6.27