Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Add test for writing nexus files early#680

Merged
d-perl merged 1 commit into
mainfrom
677_unit_test_for_non_existant_h5_files
May 24, 2023
Merged

Add test for writing nexus files early#680
d-perl merged 1 commit into
mainfrom
677_unit_test_for_non_existant_h5_files

Conversation

@DominicOram

@DominicOram DominicOram commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Fixes #677

To test:

  1. Confirm tests fail after pip install nexgen==0.6.26
  2. Confirm tests pass after pip install nexgen==0.6.27
  3. Confirm commented issue will solve skipped test

@codecov

codecov Bot commented May 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #680 (481a308) into main (bc18cce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files          34       34           
  Lines        1494     1494           
=======================================
  Hits         1341     1341           
  Misses        153      153           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d-perl d-perl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass and fail as described, the skipped test previously worked for correct nexus files so that issue should fix it. thanks!

@d-perl
d-perl merged commit 461e079 into main May 24, 2023
@d-perl
d-perl deleted the 677_unit_test_for_non_existant_h5_files branch May 24, 2023 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a unit test for h5 files not existing yet

2 participants