This repository was archived by the owner on Sep 2, 2024. It is now read-only.
678 pydantic internal params#682
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 89.75% 89.71% -0.04%
==========================================
Files 34 34
Lines 1494 1498 +4
==========================================
+ Hits 1341 1344 +3
- Misses 153 154 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
noemifrisina
approved these changes
May 24, 2023
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
Tests pass (usual TimeoutErrors notwithstanding), looks okay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 678
Makes all the internal param classes into pydantic models. Does not yet do it for InternalParameters because that is more complicated - new issue for this: #681
Link to dodal PR (if required): DiamondLightSource/dodal#68
To test: