Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

678 pydantic internal params#682

Merged
noemifrisina merged 5 commits into
mainfrom
678_pydantic_internal_params
May 24, 2023
Merged

678 pydantic internal params#682
noemifrisina merged 5 commits into
mainfrom
678_pydantic_internal_params

Conversation

@d-perl

@d-perl d-perl commented May 23, 2023

Copy link
Copy Markdown
Contributor

Fixes 678
Makes all the internal param classes into pydantic models. Does not yet do it for InternalParameters because that is more complicated - new issue for this: #681

Link to dodal PR (if required): DiamondLightSource/dodal#68

To test:

  1. Run tests

@codecov

codecov Bot commented May 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #682 (aaf024b) into main (461e079) will decrease coverage by 0.04%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   89.75%   89.71%   -0.04%     
==========================================
  Files          34       34              
  Lines        1494     1498       +4     
==========================================
+ Hits         1341     1344       +3     
- Misses        153      154       +1     
Impacted Files Coverage Δ
...ameters/internal_parameters/internal_parameters.py 97.75% <87.50%> (-1.17%) ⬇️
...emis/external_interaction/ispyb/ispyb_dataclass.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noemifrisina noemifrisina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass (usual TimeoutErrors notwithstanding), looks okay

@noemifrisina
noemifrisina merged commit c4c24bb into main May 24, 2023
@noemifrisina
noemifrisina deleted the 678_pydantic_internal_params branch May 24, 2023 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants