Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

change i03 import paths#692

Merged
d-perl merged 9 commits into
mainfrom
dodal_69_add_i24
May 31, 2023
Merged

change i03 import paths#692
d-perl merged 9 commits into
mainfrom
dodal_69_add_i24

Conversation

@d-perl

@d-perl d-perl commented May 31, 2023

Copy link
Copy Markdown
Contributor

@noemifrisina noemifrisina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a couple of tests are failing because active_device_is_same_type is not in i03.py anymore but in beamline_utils, aside from that seems okay

@d-perl d-perl changed the title change i03 import path change i03 import paths May 31, 2023
@codecov

codecov Bot commented May 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #692 (8872a06) into main (7115c93) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files          36       36           
  Lines        1634     1634           
=======================================
  Hits         1501     1501           
  Misses        133      133           
Impacted Files Coverage Δ
...rc/artemis/experiment_plans/fast_grid_scan_plan.py 86.98% <100.00%> (ø)
src/artemis/experiment_plans/full_grid_scan.py 70.31% <100.00%> (ø)
...rtemis/experiment_plans/oav_grid_detection_plan.py 100.00% <100.00%> (ø)
src/artemis/experiment_plans/rotation_scan_plan.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d-perl
d-perl merged commit e5e8311 into main May 31, 2023
@d-perl
d-perl deleted the dodal_69_add_i24 branch May 31, 2023 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants