This repository was archived by the owner on Sep 2, 2024. It is now read-only.
695 nexus writer get documents from plan#696
Merged
Merged
Conversation
- separate out preprocessing functions from internal param base class - simplify internal param base classes - implement processing in validators - propagate json decoders from children
Codecov Report
@@ Coverage Diff @@
## main DiamondLightSource/hyperion#696 +/- ##
==========================================
+ Coverage 91.59% 92.06% +0.46%
==========================================
Files 34 35 +1
Lines 1666 1713 +47
==========================================
+ Hits 1526 1577 +51
+ Misses 140 136 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
suggested changes
Jun 8, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Nice, great refactor, thanks! A few comments in code. Also, can you add a couple of nexus callback tests on the unhappy path e.g. that we get sensible errors if it does not get the docs in the right order
DominicOram
reviewed
Jun 12, 2023
Comment on lines
61
to
63
| assert ( | ||
| self.nexus_writer_1 is not None and self.nexus_writer_2 is not None | ||
| ), "Failed to create Nexus files, writers were not initialised." |
Collaborator
There was a problem hiding this comment.
Should: This assertion now seems over the top given we just created the writers
DominicOram
approved these changes
Jun 12, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Brilliant, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #695
somewhat reorganises the fgs nexus writer callback, lets it get parameters through documents, and changes where in the plan subscription is done
associated dodal PR: DiamondLightSource/dodal#89
To test: