572 deploy dodal as repo in prod fixed

[olliesilvester]

Fixes #572 and #627

To test:

1. Run "deploy_artemis.py dev" and confirm issue requirements are satifsfied, and that the symlink is correct
2. Confirm beamline deployment location is correct

[codecov]

Codecov Report

Merging #704 (be37aad) into main (6850043) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          34       34           
  Lines        1666     1666           
=======================================
  Hits         1526     1526           
  Misses        140      140           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[olliesilvester]

@DominicOram once this is merged, need to merge GDA changes

[d-perl]

If I try to run either
python deploy/deploy_artemis.py dev or ./deploy/deploy_artemis.sh dev I get a:
PermissionError: [Errno 13] Permission denied: './dls_dev_env.sh'
In a freshly cloned repo from this branch. I think it's probably because it writes to /tmp/ and the system policy here is to not allow execution from /tmp/
I feel that the bash script should have a --help option, and the script should let you specify the location for a dev installation, as well as maybe warning that /tmp/ is not suitable (on RHEL8, anyway)

[olliesilvester]

If I try to run either python deploy/deploy_artemis.py dev or ./deploy/deploy_artemis.sh dev I get a: PermissionError: [Errno 13] Permission denied: './dls_dev_env.sh' In a freshly cloned repo from this branch. I think it's probably because it writes to /tmp/ and the system policy here is to not allow execution from /tmp/

Are you able to run deploy_artemis.py dev from the main branch? That script also runs ./dls_dev_env.sh from /tmp/

[d-perl]

Yeah, can't run that one either. so I guess it is technically a separate issue that this doesn't work on rhel8 but we might as well fix it

[olliesilvester]

It works on my Red Hat 8 machine, but I can look into what's causing the permission error

[d-perl]

oh, interesting. I wonder if I just need to get someone to change the security policy for my machine then.

[d-perl]

On discussion, we will ignor potential security policy interference in execution from /tmp/ since that doesn't affect many people. will revisit if it becomes a bigger problem