This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Add testing for fast grid scan without grid detect#752
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 37 37
Lines 1808 1808
=======================================
Hits 1703 1703
Misses 105 105 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
suggested changes
Jun 26, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Good test but I think we should change it slightly as in comment
Comment on lines
+396
to
+404
| RE(bps.stage(fake_fgs_composite.eiger)) | ||
| fake_fgs_composite.eiger.arming_status.wait(60) | ||
| fake_fgs_composite.eiger._wait_fan_ready.assert_called_once() |
Collaborator
There was a problem hiding this comment.
Must: I think the test needs to assert that after the stage we're armed without needing to do a wait (to get it consistent we may need one of the mock sets to take some fraction of time)
olliesilvester
force-pushed
the
686_fgs_arms_eiger_without_grid_detect
branch
from
June 28, 2023 13:09
bc53f97 to
5a670b7
Compare
olliesilvester
marked this pull request as ready for review
June 28, 2023 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #686
Link to dodal PR (if required): DiamondLightSource/dodal#92
The unit test seems to work but takes a long time to complete for some reason
To test:
Confirm unit test is sensible