Improvements to rotation scans from live tests inc. accel & shutter time#757
Conversation
Codecov Report
@@ Coverage Diff @@
## main DiamondLightSource/hyperion#757 +/- ##
==========================================
+ Coverage 94.38% 94.46% +0.07%
==========================================
Files 40 40
Lines 2013 2042 +29
==========================================
+ Hits 1900 1929 +29
Misses 113 113
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
left a comment
There was a problem hiding this comment.
Sorry, I went quite overboard here with comments, as discussed it became a bit of a review of rotation scans in general. Feel free to spin out into PRs and/or argue with me
|
@DominicOram are the new issues enough or are there things that you would like fixed in this PR? |
DominicOram
left a comment
There was a problem hiding this comment.
I'm happy that all issues have either been addressed or spun out. Thanks!
Fixes #756 and fixes #816
DODAL PR: DiamondLightSource/dodal#130
To test: run tests
Don't be afraid of the line count! it's almost all extra config files and test boilerplate!