This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Apply flatfield by default when changing zoom level#758
Merged
Conversation
noemifrisina
approved these changes
Jun 28, 2023
Contributor
|
Merge conflict to be addressed before merging |
noemifrisina
suggested changes
Jul 3, 2023
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
It looks like the failing tests are due to changes in Pydantic v2, which was just released.
I think we could pin the pydantic version to pydantic<2.0 in setup.cfg for this one and fix the issue in a separate PR
Collaborator
Author
|
Broken test is due to #763 |
noemifrisina
approved these changes
Jul 4, 2023
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks okay aside from merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/dodal#103
This mainly just removes the need for Artemis to set the plugins for the OAV as this is handled inside the device when zoom level is changed
Link to dodal PR (if required): DiamondLightSource/dodal#104
To test: