This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Unstage detector if there is an issue in grid detection#772
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 93.26% 93.25% -0.01%
==========================================
Files 37 37
Lines 1855 1854 -1
==========================================
- Hits 1730 1729 -1
Misses 125 125
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
noemifrisina
suggested changes
Jul 3, 2023
| ) | ||
|
|
||
| # Check detector was armed | ||
| eiger.do_arm.set.assert_called_once_with(1) |
Contributor
There was a problem hiding this comment.
It looks like the exception was raised before the detector was armed as this fails with an AssertionError becauseset is never called.
FAILED src/artemis/experiment_plans/tests/test_full_grid_scan_plan.py::test_grid_detection_running_when_exception_raised_then_eiger_unstaged - AssertionError: Expected 'set' to be called once. Called 0 times.
Collaborator
Author
|
Works on my machine and in CI, could be |
noemifrisina
approved these changes
Jul 6, 2023
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
Yes, sorry, turns out it was the dodal version. I was on main before that commit was merged. All good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #765
To test: