This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Add pydantic dependency explicitly to artemis#775
Merged
Conversation
noemifrisina
approved these changes
Jul 4, 2023
noemifrisina
left a comment
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
Aside from known error from #763 , looks fine. Everything runs and unit tests pass
Codecov Report
@@ Coverage Diff @@
## main #775 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 37 37
Lines 1855 1855
=======================================
Hits 1730 1730
Misses 125 125 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #774
To test:
./dls_dev_env.shand confirm tests pass