This repository was archived by the owner on Sep 2, 2024. It is now read-only.
632 get flux from pv#785
Merged
Merged
Conversation
noemifrisina
marked this pull request as draft
July 10, 2023 14:07
noemifrisina
marked this pull request as ready for review
July 11, 2023 10:43
DominicOram
self-requested a review
July 12, 2023 15:33
DominicOram
suggested changes
Jul 12, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Good work, thank you. The test is failing because you need to patch the device in test_when_blueskyrunner_initiated_then_plans_are_setup_and_devices_connected, can you please add it in. We should add it in to S03 though but we can merge this without doing so
DominicOram
approved these changes
Jul 12, 2023
| assert test_args == ("DEBUG", True, True, True) | ||
|
|
||
|
|
||
| @patch("dodal.beamlines.i03.flux") |
Collaborator
There was a problem hiding this comment.
Must: You need to patch the Device, not teh function. I've fixed it :)
Codecov Report
@@ Coverage Diff @@
## main #785 +/- ##
==========================================
+ Coverage 93.25% 93.26% +0.01%
==========================================
Files 37 37
Lines 1854 1857 +3
==========================================
+ Hits 1729 1732 +3
Misses 125 125
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #632
Link to dodal PR (if required): #113
To test: