Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Correct the grid overlay drawing#802

Merged
DominicOram merged 3 commits into
mainfrom
770_correct_upper_left
Jul 18, 2023
Merged

Correct the grid overlay drawing#802
DominicOram merged 3 commits into
mainfrom
770_correct_upper_left

Conversation

@DominicOram

Copy link
Copy Markdown
Collaborator

Fixes #770

To test:

  1. Confirm tests are sensible and pass

@noemifrisina

Copy link
Copy Markdown
Contributor

CI test broken because of #781

@codecov

codecov Bot commented Jul 17, 2023

Copy link
Copy Markdown

Codecov Report

Merging #802 (8db9d78) into main (d7b0ebe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #802   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          37       37           
  Lines        1866     1867    +1     
=======================================
+ Hits         1741     1742    +1     
  Misses        125      125           
Impacted Files Coverage Δ
...rtemis/experiment_plans/oav_grid_detection_plan.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noemifrisina noemifrisina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing now, thanks

@DominicOram
DominicOram merged commit cf1e9fc into main Jul 18, 2023
@DominicOram
DominicOram deleted the 770_correct_upper_left branch July 18, 2023 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm drawn overlay correct

2 participants