This repository was archived by the owner on Sep 2, 2024. It is now read-only.
remove dataclasses_json#817
Merged
Merged
Conversation
DominicOram
approved these changes
Jul 24, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks. Query in code, take it or leave it as part of this issue
|
|
||
| @dataclass | ||
| class GridScanWithEdgeDetectParams(DataClassJsonMixin, AbstractExperimentParameterBase): | ||
| class GridScanWithEdgeDetectParams(AbstractExperimentParameterBase): |
Collaborator
There was a problem hiding this comment.
Query: RotationScanParams inherits from BaseModel. Do we have a preference on when to do that and when to use pydantic.dataclass? From a google I think maybe BaseModel gives you more? So I would suggest we standardise on them all using BaseModel? This may be a different ticket...
Contributor
Author
There was a problem hiding this comment.
Yes, maybe it's better to use models for all of them, I just changed the ones which were still dataclass because it was easier
Collaborator
There was a problem hiding this comment.
Cool, I'll make an issue
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #815
To test: