Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

369 rotation call zocalo#831

Merged
DominicOram merged 7 commits into
mainfrom
369_rotation_call_zocalo
Aug 3, 2023
Merged

369 rotation call zocalo#831
DominicOram merged 7 commits into
mainfrom
369_rotation_call_zocalo

Conversation

@d-perl

@d-perl d-perl commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Fixes #369

adds a simple callback to trigger run_start and run_end in zocalo for rotation scans

To test:

  1. Run tests

@d-perl
d-perl requested a review from DominicOram July 28, 2023 16:54
@codecov

codecov Bot commented Jul 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #831 (954dd66) into main (1efedcc) will increase coverage by 0.07%.
Report is 38 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
+ Coverage   94.38%   94.46%   +0.07%     
==========================================
  Files          40       41       +1     
  Lines        2013     2040      +27     
==========================================
+ Hits         1900     1927      +27     
  Misses        113      113              
Files Changed Coverage Δ
.../external_interaction/zocalo/zocalo_interaction.py 97.18% <ø> (ø)
src/artemis/device_setup_plans/setup_oav.py 97.56% <100.00%> (+0.19%) ⬆️
...callbacks/rotation/rotation_callback_collection.py 100.00% <100.00%> (ø)
..._interaction/callbacks/rotation/zocalo_callback.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments. I think there may be a possibility to share more with the FGS one but I actually like keeping it a bit separate in this case

Comment thread src/artemis/experiment_plans/tests/conftest.py
@d-perl
d-perl requested a review from DominicOram August 1, 2023 09:30

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram
DominicOram merged commit 7710aaf into main Aug 3, 2023
@DominicOram
DominicOram deleted the 369_rotation_call_zocalo branch August 3, 2023 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm Zocalo handler deal with rotation scans

2 participants