This repository was archived by the owner on Sep 2, 2024. It is now read-only.
369 rotation call zocalo#831
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
==========================================
+ Coverage 94.38% 94.46% +0.07%
==========================================
Files 40 41 +1
Lines 2013 2040 +27
==========================================
+ Hits 1900 1927 +27
Misses 113 113
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
suggested changes
Jul 31, 2023
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, minor comments. I think there may be a possibility to share more with the FGS one but I actually like keeping it a bit separate in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #369
adds a simple callback to trigger
run_startandrun_endin zocalo for rotation scansTo test: