This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Fix flaky zebra tests#844
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 94.38% 94.39%
=======================================
Files 40 40
Lines 2013 2016 +3
=======================================
+ Hits 1900 1903 +3
Misses 113 113
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d-perl
approved these changes
Aug 1, 2023
d-perl
left a comment
d-perl
left a comment
Contributor
There was a problem hiding this comment.
Sure, I guess I agree this would probably be the issue? I haven't noticed the tests being flaky (locally anyway)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #843
To test:
Given the test is flaky I'm not sure we can reliably test this fixes the issue but I guess check if you agree that this is probably the issue