Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Allow specifying the grid size in microns#846

Merged
DominicOram merged 3 commits into
mainfrom
845_gridscan_width
Aug 9, 2023
Merged

Allow specifying the grid size in microns#846
DominicOram merged 3 commits into
mainfrom
845_gridscan_width

Conversation

@DominicOram

Copy link
Copy Markdown
Collaborator

Fixes #845

To test:

  1. Confirm tests still pass

@DominicOram
DominicOram requested a review from d-perl August 1, 2023 16:11
@codecov

codecov Bot commented Aug 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #846 (b8153c5) into main (4ee4e97) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files          42       42           
  Lines        2112     2114    +2     
=======================================
+ Hits         1998     2000    +2     
  Misses        114      114           
Files Changed Coverage Δ
src/artemis/experiment_plans/full_grid_scan.py 100.00% <ø> (ø)
...rtemis/experiment_plans/oav_grid_detection_plan.py 100.00% <100.00%> (ø)
...plan_specific/grid_scan_with_edge_detect_params.py 96.00% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d-perl d-perl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should update params version, otherwise great

@DominicOram

Copy link
Copy Markdown
Collaborator Author

Sure, I think given it's optional and we just did a v6 release I only want to bump a minor Artemis version though

@DominicOram

Copy link
Copy Markdown
Collaborator Author

Given parameter change could you review https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/39676 too

@DominicOram
DominicOram merged commit 104351d into main Aug 9, 2023
@DominicOram
DominicOram deleted the 845_gridscan_width branch August 9, 2023 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting grid scan width in microns

2 participants